NPE when hitting GWT with random gmaps coordinates

[aaime]

Trying to hit gmaps with a hand made, out of the blue request like:

http://atlas.openplans.org:8080/geoserver_csv/gwc/service/gmaps?layers=topp:AmericanIndianorAlaskanNativeOnlyNonHispanic_view&zoom=2&x=10&y=0

results in a null pointer exception with the following stack trace:

java.lang.NullPointerException?

at org.geowebcache.util.wms.GridCalculator?.locationWithinBounds(GridCalc?

ulator.java:245)

at org.geowebcache.layer.wms.WMSLayer.getResponse(WMSLayer.java:226)
at org.geowebcache.GeoWebCacheDispatcher?.handleServiceRequest(GeoWebCach?

eDispatcher.java:242)

at org.geowebcache.GeoWebCacheDispatcher?.handleRequestInternal(GeoWebCac?

heDispatcher.java:141)

at org.springframework.web.servlet.mvc.AbstractController?.handleRequest(

AbstractController?.java:139)

at org.springframework.web.servlet.mvc.SimpleControllerHandlerAdapter?.ha

ndle(SimpleControllerHandlerAdapter?.java:44)

at org.springframework.web.servlet.DispatcherServlet?.doDispatch(Dispatch

erServlet.java:684)

at org.springframework.web.servlet.DispatcherServlet?.doService(Dispatche

rServlet.java:625)

at org.springframework.web.servlet.FrameworkServlet?.processRequest(Frame

workServlet.java:392)

This is probably due to the x/y coordinates to be out of the acceptable range for that layer, nevertheless a better error message would be advisable (something like "requested area outside of valid bounds for layer xxx" or something like that).

[arneke]

Fixed in r218, GMapsConverter and MGMapsConverter should have thrown a readable exception earlier.